feat: dont render close button if no close handler is passed#110
Merged
adefreitas merged 3 commits intoStackOneHQ:mainfrom Mar 17, 2026
Merged
feat: dont render close button if no close handler is passed#110adefreitas merged 3 commits intoStackOneHQ:mainfrom
adefreitas merged 3 commits intoStackOneHQ:mainfrom
Conversation
jpmiguel
previously approved these changes
Mar 17, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jpmiguel
previously approved these changes
Mar 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the integration picker success-state footer so the “Close” action is only shown when a close handler is provided, preventing a non-functional close button from being rendered.
Changes:
- Make
SuccessCardFooter’sonCloseprop optional and conditionally render the Close button. - Pass
onClosethrough directly fromIntegrationPickerinstead of wrapping it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/modules/integration-picker/components/successCardFooter.tsx |
Makes onClose optional and renders the Close button only when a handler exists. |
src/modules/integration-picker/IntegrationPicker.tsx |
Passes onClose directly into the success footer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/modules/integration-picker/components/successCardFooter.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Make SuccessCardFooter optional: show the Close button only when
onCloseis provided and hide the whole footer when there are no links and no close action.IntegrationPickernow passesonClosethrough directly, and lint warnings were fixed.Written for commit 9758683. Summary will update on new commits.